lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] watchdog: mtx-1: Drop au1000.h header inclusion
From
Date
On 12/11/19 1:02 PM, Florian Fainelli wrote:
> Including au1000.h from the machine specific header directory prevents
> this driver from being built on any other platforms (MIPS included).
> Since we do not use any definitions, drop it.
>
> Reported-by: Denis Efremov <efremov@linux.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/watchdog/mtx-1_wdt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
> index 25a92857b217..aeca22f7450e 100644
> --- a/drivers/watchdog/mtx-1_wdt.c
> +++ b/drivers/watchdog/mtx-1_wdt.c
> @@ -41,8 +41,6 @@
> #include <linux/uaccess.h>
> #include <linux/gpio/consumer.h>
>
> -#include <asm/mach-au1x00/au1000.h>
> -
> #define MTX1_WDT_INTERVAL (5 * HZ)
>
> static int ticks = 100 * HZ;
>

Given that this is nothing but yet another gpio watchdog driver, I'd
personally rather have it merged with gpio_wdt.c. On a higher level,
cleaning up old-style watchdog drivers, without converting them to
using the watchdog core, is a waste of time.

Wim, should we make it a policy to reject patches into old-style drivers
unless they fix a real bug ? It is getting a pain to have to review those
patches.

Thanks,
Guenter

\
 
 \ /
  Last update: 2019-12-12 02:36    [W:0.065 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site