Messages in this thread | | | From | Joel Stanley <> | Date | Thu, 12 Dec 2019 00:12:43 +0000 | Subject | Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency |
| |
On Wed, 11 Dec 2019 at 19:28, Brendan Higgins <brendanhiggins@google.com> wrote: > > Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > the following build error: > > ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe': > drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource' > > Fix the build error by adding the unspecified dependency. > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in order to build some ARM drivers under UM. Do you have plans to fix that too?
Do you want to get this in a fix for 5.5?
Acked-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
> --- > drivers/fsi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig > index 92ce6d85802cc..4cc0e630ab79b 100644 > --- a/drivers/fsi/Kconfig > +++ b/drivers/fsi/Kconfig > @@ -55,6 +55,7 @@ config FSI_MASTER_AST_CF > > config FSI_MASTER_ASPEED > tristate "FSI ASPEED master" > + depends on HAS_IOMEM > help > This option enables a FSI master that is present behind an OPB bridge > in the AST2600. > -- > 2.24.0.525.g8f36a354ae-goog >
| |