Messages in this thread | | | From | Haiyang Zhang <> | Subject | RE: [PATCH] Fix tx_table init in rndis_set_subchannel() | Date | Wed, 11 Dec 2019 22:23:55 +0000 |
| |
> -----Original Message----- > From: linux-hyperv-owner@vger.kernel.org <linux-hyperv- > owner@vger.kernel.org> On Behalf Of David Miller > Sent: Wednesday, December 11, 2019 5:22 PM > To: Haiyang Zhang <haiyangz@microsoft.com> > Cc: sashal@kernel.org; linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; > KY Srinivasan <kys@microsoft.com>; Stephen Hemminger > <sthemmin@microsoft.com>; olaf@aepfle.de; vkuznets > <vkuznets@redhat.com>; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] Fix tx_table init in rndis_set_subchannel() > > From: Haiyang Zhang <haiyangz@microsoft.com> > Date: Wed, 11 Dec 2019 13:59:03 -0800 > > > Host can provide send indirection table messages anytime after RSS is > > enabled by calling rndis_filter_set_rss_param(). So the host provided > > table values may be overwritten by the initialization in > > rndis_set_subchannel(). > > > > To prevent this problem, move the tx_table initialization before > > calling rndis_filter_set_rss_param(). > > > > Fixes: a6fb6aa3cfa9 ("hv_netvsc: Set tx_table to equal weight after > > subchannels open") > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > > Please format your subject lines properly. > > [PATCH $version $GIT_TREE] $subsystem_prefix: $description > > Even the Fixes: tag had the proper subsystem prefix in it. > > So your next posting must be of the form: > > [PATCH v2 net] hv_netvsc: Fix tx_table init in rndis_set_subchannel().
Will do. Thanks.
| |