Messages in this thread | | | Date | Wed, 11 Dec 2019 20:02:35 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2] iommu/dma: Rationalise types for DMA masks |
| |
On Wed, Dec 11, 2019 at 06:33:26PM +0000, Robin Murphy wrote: > Since iommu_dma_alloc_iova() combines incoming masks with the u64 bus > limit, it makes more sense to pass them around in their native u64 > rather than converting to dma_addr_t early. Do that, and resolve the > remaining type discrepancy against the domain geometry with a cheeky > cast to keep things simple. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Joerg, let me know if you want to pick this up through the iommu tree as it touches the iommu code, or through the dma-mapping tree that introduced the warning.
| |