Messages in this thread | | | Date | Wed, 11 Dec 2019 12:00:51 -0500 | From | Steven Rostedt <> | Subject | Re: ftrace histogram sorting broken on BE architecures |
| |
On Wed, 11 Dec 2019 10:37:18 -0600 Tom Zanussi <zanussi@kernel.org> wrote:
> > Tom, > > > > Correct me if I'm wrong, from what I can tell, all sums and keys are > > u64 unless they are a string. Thus, I believe this patch should not > > have any issues. > > The sums are u64, but the keys may not be. I'll take a look and see,
Are they? I see in create_key_field:
key_size = ALIGN(key_size, sizeof(u64));
Which to me seems that we'll have nothing smaller than sizeof(u64).
> but I'm out today and won't be able to look into it until tomorrow, if > that's ok.
No rush.
I'll start the testing of this patch if you come back and say its fine ;-) That takes a full day.
-- Steve
| |