lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 011/134] tools/power/x86/intel-speed-select: Remove warning for unused result
    Date
    From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

    [ Upstream commit abd120e3bdf3dd72ba1ed9ac077a861e0e3dc43a ]

    Fix warning for:
    isst-config.c: In function ‘set_cpu_online_offline’:
    isst-config.c:221:3: warning: ignoring return value of ‘write’,
    declared with attribute warn_unused_result [-Wunused-result]
    write(fd, "1\n", 2);

    Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/power/x86/intel-speed-select/isst-config.c | 9 ++++++---
    1 file changed, 6 insertions(+), 3 deletions(-)

    diff --git a/tools/power/x86/intel-speed-select/isst-config.c b/tools/power/x86/intel-speed-select/isst-config.c
    index 2a9890c8395a4..21fcfe621d3aa 100644
    --- a/tools/power/x86/intel-speed-select/isst-config.c
    +++ b/tools/power/x86/intel-speed-select/isst-config.c
    @@ -169,7 +169,7 @@ int get_topo_max_cpus(void)
    static void set_cpu_online_offline(int cpu, int state)
    {
    char buffer[128];
    - int fd;
    + int fd, ret;

    snprintf(buffer, sizeof(buffer),
    "/sys/devices/system/cpu/cpu%d/online", cpu);
    @@ -179,9 +179,12 @@ static void set_cpu_online_offline(int cpu, int state)
    err(-1, "%s open failed", buffer);

    if (state)
    - write(fd, "1\n", 2);
    + ret = write(fd, "1\n", 2);
    else
    - write(fd, "0\n", 2);
    + ret = write(fd, "0\n", 2);
    +
    + if (ret == -1)
    + perror("Online/Offline: Operation failed\n");

    close(fd);
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-12-11 17:11    [W:2.213 / U:1.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site