lkml.org 
[lkml]   [2019]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 004/243] lp: fix sparc64 LPSETTIMEOUT ioctl
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    commit 45a2d64696b11913bcf1087b041740edbade3e21 upstream.

    The layout of struct timeval is different on sparc64 from
    anything else, and the patch I did long ago failed to take
    this into account.

    Change it now to handle sparc64 user space correctly again.

    Quite likely nobody cares about parallel ports on sparc64,
    but there is no reason not to fix it.

    Cc: stable@vger.kernel.org
    Fixes: 9a450484089d ("lp: support 64-bit time_t user space")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/r/20191108203435.112759-7-arnd@arndb.de
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/char/lp.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/char/lp.c
    +++ b/drivers/char/lp.c
    @@ -708,6 +708,10 @@ static int lp_set_timeout64(unsigned int
    if (copy_from_user(karg, arg, sizeof(karg)))
    return -EFAULT;

    + /* sparc64 suseconds_t is 32-bit only */
    + if (IS_ENABLED(CONFIG_SPARC64) && !in_compat_syscall())
    + karg[1] >>= 32;
    +
    return lp_set_timeout(minor, karg[0], karg[1]);
    }


    \
     
     \ /
      Last update: 2019-12-11 16:55    [W:2.546 / U:0.988 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site