Messages in this thread | | | Date | Tue, 10 Dec 2019 11:11:42 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH v3 2/5] phy: qcom-qmp: Increase PHY ready timeout |
| |
On Tue 10 Dec 10:47 PST 2019, Evan Green wrote:
> On Wed, Nov 6, 2019 at 4:09 PM Bjorn Andersson > <bjorn.andersson@linaro.org> wrote: > > > > It's typical for the QHP PHY to take slightly above 1ms to initialize, > > so increase the timeout of the PHY ready check to 10ms - as already done > > in the downstream PCIe driver. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > Tested-by: Evan Green <evgreen@chromium.org> >
Thanks.
> Should this have a Fixes tag for 14ced7e3a1ae9 ("phy: qcom-qmp: > Correct ready status, again")?
For UFS it would be 885bd765963b ("phy: qcom-qmp: Correct READY_STATUS poll break condition"), but I think that before the two we would exit the poll immediately, so we would only hit the timeout in the "error" case - where the PHY did come up in a timely fashion.
So I don't think there is a particular commit to "Fixes:"...
But given that this is no longer only needed for the (new) QHP PCIe instance it would be reasonable to Cc: stable, to get it into v5.4
Regards, Bjorn
| |