Messages in this thread | | | Subject | Re: [PATCH] initramfs: forcing panic when kstrdup failed | From | David Engraf <> | Date | Tue, 10 Dec 2019 08:07:41 +0100 |
| |
On 10.12.19 at 03:48, zhanglin wrote: > preventing further undefined behaviour when kstrdup failed. > > Signed-off-by: zhanglin <zhang.lin16@zte.com.cn> > --- > init/initramfs.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/init/initramfs.c b/init/initramfs.c > index fca899622937..39a4fba48cc7 100644 > --- a/init/initramfs.c > +++ b/init/initramfs.c > @@ -125,6 +125,8 @@ static void __init dir_add(const char *name, time64_t mtime) > panic("can't allocate dir_entry buffer"); > INIT_LIST_HEAD(&de->list); > de->name = kstrdup(name, GFP_KERNEL); > + if (!de->name) > + panic("can't allocate dir_entry.name buffer"); > de->mtime = mtime; > list_add(&de->list, &dir_list); > } > @@ -340,6 +342,8 @@ static int __init do_name(void) > if (body_len) > ksys_ftruncate(wfd, body_len); > vcollected = kstrdup(collected, GFP_KERNEL); > + if (!vcollected) > + panic("can not allocate vcollected buffer.");
I would change the message to have the same naming as the other out of memory messages:
panic("can't allocate vcollected buffer");
Best regards - David
> state = CopyFile; > } > } >
| |