Messages in this thread | | | Date | Tue, 10 Dec 2019 15:27:49 +0100 | From | Jiri Pirko <> | Subject | Re: [PATCH net-next v2 5/5] ethtool: provide link mode names as a string set |
| |
Tue, Dec 10, 2019 at 02:08:13PM CET, mkubecek@suse.cz wrote: >Unlike e.g. netdev features, the ethtool ioctl interface requires link mode >table to be in sync between kernel and userspace for userspace to be able >to display and set all link modes supported by kernel. The way arbitrary >length bitsets are implemented in netlink interface, this will be no longer >needed. > >To allow userspace to access all link modes running kernel supports, add >table of ethernet link mode names and make it available as a string set to >userspace GET_STRSET requests. Add build time check to make sure names >are defined for all modes declared in enum ethtool_link_mode_bit_indices. > >Once the string set is available, make it also accessible via ioctl. > >Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
| |