Messages in this thread | | | Date | Tue, 10 Dec 2019 13:51:12 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 09/10] PCMCIA/i82092: improve enter/leave macro |
| |
On Tue, Dec 10, 2019 at 12:43:34PM +0100, Simon Geis wrote: > Improve the log output by adding additional macros dev_enter/dev_leave > in i82092aa.h which print out device information. > > dev_leave takes a second parameter to print out further > information when needed. Use __func__ instead of function name > in the header file. > > Co-developed-by: Lukas Panzer <lukas.panzer@fau.de> > Signed-off-by: Lukas Panzer <lukas.panzer@fau.de> > Signed-off-by: Simon Geis <simon.geis@fau.de> > > --- > drivers/pcmcia/i82092.c | 59 ++++++++++++++++++++------------------- > drivers/pcmcia/i82092aa.h | 16 ++++++++--- > 2 files changed, 42 insertions(+), 33 deletions(-) > > diff --git a/drivers/pcmcia/i82092.c b/drivers/pcmcia/i82092.c > index f523a810ab66..668a2188ef66 100644 > --- a/drivers/pcmcia/i82092.c > +++ b/drivers/pcmcia/i82092.c > @@ -76,7 +76,7 @@ static int i82092aa_pci_probe(struct pci_dev *dev, > unsigned char configbyte; > int i, ret; > > - enter("i82092aa_pci_probe"); > + dev_enter(&dev->dev);
Ugh, these should just all be deleted now that we have ftrace, right? There is no need for any "we entered/left a function!" print messages needed in the kernel anymore.
thanks,
greg k-h
| |