Messages in this thread | | | Subject | Re: [PATCH v2 5/8] iommu/vt-d: Add first level page table interfaces | From | Lu Baolu <> | Date | Wed, 11 Dec 2019 09:56:53 +0800 |
| |
Hi Jacob,
On 12/3/19 7:27 AM, Jacob Pan wrote: > On Thu, 28 Nov 2019 10:25:47 +0800 > Lu Baolu <baolu.lu@linux.intel.com> wrote: > >> This adds functions to manipulate first level page tables >> which could be used by a scalale mode capable IOMMU unit. >> > FL and SL page tables are very similar, and I presume we are not using > all the flag bits in FL paging structures for DMA mapping. Are there > enough relevant differences to warrant a new set of helper functions > for FL? Or we can merge into one.
I evaluated your suggestion these days. It turned out that your suggestion make code simpler and easier for maintainence. Thank you for the comment and I will send out a new version for review soon.
Best regards, baolu
| |