lkml.org 
[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ELF: don't copy ELF header around
On Sun, 8 Dec 2019 20:12:42 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:

> ELF header is read into bprm->buf[] by generic execve code.
>
> Save a memcpy and allocate just one header for the interpreter instead
> of two headers (64 bytes instead of 128 on 64-bit).

Hard to review. Why were there two copies in the first place? Because
of the need to modify the caller's version when we do
`loc->elf_ex.e_entry += load_bias', yes? Any other place?

Local variable `loc' can go away now, yes?

\
 
 \ /
  Last update: 2019-12-11 02:56    [W:0.028 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site