Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 11 Dec 2019 01:44:43 +0100 | Subject | Re: [PATCH] leds: gpio: Fix uninitialized gpio label for fwnode based probe |
| |
On Thu, Dec 5, 2019 at 10:25 PM Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
> When switching to using generic LED name composition mechanism via > devm_led_classdev_register_ext() API the part of code initializing > struct gpio_led's template name property was removed alongside. > It was however overlooked that the property was also passed to > devm_fwnode_get_gpiod_from_child() in place of "label" parameter, > which when set to NULL, results in gpio label being initialized to '?'. > > It could be observed in debugfs and failed to properly identify > gpio association with LED consumer. > > Fix this shortcoming by updating the GPIO label after the LED is > registered and its final name is known. > > Fixes: d7235f5feaa0 ("leds: gpio: Use generic support for composing LED names") > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Russell King <linux@armlinux.org.uk> > Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |