lkml.org 
[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10 1/6] IMA: Check IMA policy flag
From
Date
On Tue, 2019-12-10 at 15:29 -0800, Lakshmi Ramasubramanian wrote:
> On 12/10/19 2:42 PM, Mimi Zohar wrote:
>
> > Patch descriptions aren't suppose to be written as pseudo code.  Start
> > with the current status and problem description.
> >
> > For example, "process_buffer_measurement() may be called prior to IMA being initialized, which would result in a kernel panic.  This patch ..."
> >
> > Mimi
>
> I'll update the patch description in this one and in the other patches
> per your comments.
>
> Are you done reviewing all the patches in this set?
>
> Other than the one code change per your comment on "[PATCH v10 5/6]"
> there are no other code changes I need to make?
> Just wanted to confirm.
>
> [PATCH v10 5/6] IMA: Add support to limit measuring keys
> => With the additional "uid" support this isn't necessarily true any
> more.

Yes, other than the code change needed for this and the patch
descriptions, it looks good.  Am continuing with reviewing the other
patch set - queueing "key" measurements.

Mimi

\
 
 \ /
  Last update: 2019-12-11 01:04    [W:0.033 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site