Messages in this thread | | | Subject | Re: [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk | From | Jürgen Groß <> | Date | Tue, 10 Dec 2019 06:36:18 +0100 |
| |
On 09.12.19 22:07, Nick Desaulniers wrote: > On Mon, Dec 9, 2019 at 12:14 PM Nathan Chancellor > <natechancellor@gmail.com> wrote: >> >> Clang warns: >> >> ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; >> statement is not part of the previous 'if' [-Wmisleading-indentation] >> nr_parts = PARTS_PER_DISK; >> ^ >> ../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here >> if (err) >> ^ >> >> This is because there is a space at the beginning of this line; remove >> it so that the indentation is consistent according to the Linux kernel >> coding style and clang no longer warns. >> >> While we are here, the previous line has some trailing whitespace; clean >> that up as well. >> >> Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than XENVBD") >> Link: https://github.com/ClangBuiltLinux/linux/issues/791 >> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> >> --- >> drivers/block/xen-blkfront.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c >> index a74d03913822..c02be06c5299 100644 >> --- a/drivers/block/xen-blkfront.c >> +++ b/drivers/block/xen-blkfront.c >> @@ -1113,8 +1113,8 @@ static int xlvbd_alloc_gendisk(blkif_sector_t capacity, > > While you're here, would you please also removing the single space > before the labels in this function?
AFAIK those are intended to be there.
Having labels indented by a space makes diff not believe those are function declarations. So a patching a function with a label won't show the label, but the function in the diff block header.
Juergen
| |