lkml.org 
[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 146/177] RDMA/qib: Validate ->show()/store() callbacks before calling them
    Date
    From: Viresh Kumar <viresh.kumar@linaro.org>

    [ Upstream commit 7ee23491b39259ae83899dd93b2a29ef0f22f0a7 ]

    The permissions of the read-only or write-only sysfs files can be
    changed (as root) and the user can then try to read a write-only file or
    write to a read-only file which will lead to kernel crash here.

    Protect against that by always validating the show/store callbacks.

    Link: https://lore.kernel.org/r/d45cc26361a174ae12dbb86c994ef334d257924b.1573096807.git.viresh.kumar@linaro.org
    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/qib/qib_sysfs.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/infiniband/hw/qib/qib_sysfs.c b/drivers/infiniband/hw/qib/qib_sysfs.c
    index ca2638d8f35ef..d831f3e61ae8f 100644
    --- a/drivers/infiniband/hw/qib/qib_sysfs.c
    +++ b/drivers/infiniband/hw/qib/qib_sysfs.c
    @@ -301,6 +301,9 @@ static ssize_t qib_portattr_show(struct kobject *kobj,
    struct qib_pportdata *ppd =
    container_of(kobj, struct qib_pportdata, pport_kobj);

    + if (!pattr->show)
    + return -EIO;
    +
    return pattr->show(ppd, buf);
    }

    @@ -312,6 +315,9 @@ static ssize_t qib_portattr_store(struct kobject *kobj,
    struct qib_pportdata *ppd =
    container_of(kobj, struct qib_pportdata, pport_kobj);

    + if (!pattr->store)
    + return -EIO;
    +
    return pattr->store(ppd, buf, len);
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-12-10 22:38    [W:4.062 / U:0.728 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site