lkml.org 
[lkml]   [2019]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] hexagon: io: Define ioremap_uc to fix build error
From
Date
On 12/10/19 12:09 AM, Geert Uytterhoeven wrote:
> On Wed, Dec 4, 2019 at 2:34 PM Guenter Roeck <linux@roeck-us.net> wrote:
>> ioremap_uc is now mandatory.
>>
>> lib/devres.c:44:3: error: implicit declaration of function 'ioremap_uc'
>>
>> Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc")
>> Cc: Tuowen Zhao <ztuowen@gmail.com>
>> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> arch/hexagon/include/asm/io.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
>> index 539e3efcf39c..39e5605c5d42 100644
>> --- a/arch/hexagon/include/asm/io.h
>> +++ b/arch/hexagon/include/asm/io.h
>> @@ -173,7 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr)
>>
>> void __iomem *ioremap(unsigned long phys_addr, unsigned long size);
>> #define ioremap_nocache ioremap
>> -
>> +#define ioremap_uc ioremap
>>
>> #define __raw_writel writel
>
> Do we really need this? There is only one user of ioremap_uc(), which
> Christoph is trying hard to get rid of, and the new devres helper that
> triggers all of this :-(
> https://lore.kernel.org/dri-devel/20191112105507.GA7122@lst.de/
>


One may ask why we needed a devres helper in the first place if there
is indeed just one user.

Either case, I don't really care, as long as the problem is fixed.

Guenter

\
 
 \ /
  Last update: 2019-12-10 09:24    [W:0.056 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site