Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 10 Dec 2019 09:09:05 +0100 | Subject | Re: [PATCH 1/2] hexagon: define ioremap_uc |
| |
On Mon, Dec 9, 2019 at 11:30 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > Similar to > commit 38e45d81d14e ("sparc64: implement ioremap_uc") > define ioremap_uc for hexagon to avoid errors from > -Wimplicit-function-definition. > > Fixes: e537654b7039 ("lib: devres: add a helper function for ioremap_uc") > Link: https://github.com/ClangBuiltLinux/linux/issues/797 > Suggested-by: Nathan Chancellor <natechancellor@gmail.com> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > arch/hexagon/include/asm/io.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h > index 539e3efcf39c..b0dbc3473172 100644 > --- a/arch/hexagon/include/asm/io.h > +++ b/arch/hexagon/include/asm/io.h > @@ -173,6 +173,7 @@ static inline void writel(u32 data, volatile void __iomem *addr) > > void __iomem *ioremap(unsigned long phys_addr, unsigned long size); > #define ioremap_nocache ioremap > +#define ioremap_uc(X, Y) ioremap((X), (Y))
Do we really need this? There is only one user of ioremap_uc(), which Christoph is trying hard to get rid of, and the new devres helper that triggers all of this :-( https://lore.kernel.org/dri-devel/20191112105507.GA7122@lst.de/
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |