Messages in this thread | | | Subject | Re: [PATCH] drm/amd/display: include linux/slab.h where needed | From | "Kazlauskas, Nicholas" <> | Date | Tue, 10 Dec 2019 15:30:21 -0500 |
| |
On 2019-12-10 2:59 p.m., Arnd Bergmann wrote: > Calling kzalloc() and related functions requires the > linux/slab.h header to be included: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c: In function 'dcn21_ipp_create': > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c:679:3: error: implicit declaration of function 'kzalloc'; did you mean 'd_alloc'? [-Werror=implicit-function-declaration] > kzalloc(sizeof(struct dcn10_ipp), GFP_KERNEL); > > A lot of other headers also miss a direct include in this file, > but this is the only one that causes a problem for now. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
What version of the kernel are you building?
We have:
#include <linux/slab.h>
in os_types.h which gets included as part of this file:
#include <dc.h> -> #include <dc_types.h> -> #include <os_types.h>
Nicholas Kazlauskas
> --- > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c > index 906c84e6b49b..af57885bbff2 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c > @@ -23,6 +23,8 @@ > * > */ > > +#include <linux/slab.h> > + > #include "dm_services.h" > #include "dc.h" > >
| |