Messages in this thread | | | Date | Tue, 10 Dec 2019 21:12:57 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] cpu/SMT: fix x86 link error without CONFIG_SYSFS |
| |
On Tue, 10 Dec 2019, Arnd Bergmann wrote:
> When CONFIG_SYSFS is disabled, but CONFIG_HOTPLUG_SMT is enabled, > the kernel fails to link:
I wonder where such kernels are running ... or I rather don't :)
> arch/x86/power/cpu.o: In function `hibernate_resume_nonboot_cpu_disable': > (.text+0x38d): undefined reference to `cpuhp_smt_enable' > arch/x86/power/hibernate.o: In function `arch_resume_nosmt': > hibernate.c:(.text+0x291): undefined reference to `cpuhp_smt_enable' > hibernate.c:(.text+0x29c): undefined reference to `cpuhp_smt_disable' > > Move the exported functions out of the #ifdef section into its > own with the correct conditions. > > The patch that caused this is marked for stable backports, so > this one may need to be backported as well. > > Fixes: ec527c318036 ("x86/power: Fix 'nosmt' vs hibernation triple fault during resume")
Reviewed-by: Jiri Kosina <jkosina@suse.cz>
Thanks for fixing my oversight.
-- Jiri Kosina SUSE Labs
| |