lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 036/205] ASoC: meson: axg-fifo: report interrupt request failure
    Date
    From: Jerome Brunet <jbrunet@baylibre.com>

    [ Upstream commit dadfab7272b13ca441efdb9aa9117bc669680b05 ]

    Return value of request_irq() was irgnored. Fix this and report
    the failure if any

    Fixes: 6dc4fa179fb8 ("ASoC: meson: add axg fifo base driver")
    Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/meson/axg-fifo.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c
    index 30262550e37b1..0e4f65e654c4b 100644
    --- a/sound/soc/meson/axg-fifo.c
    +++ b/sound/soc/meson/axg-fifo.c
    @@ -203,6 +203,8 @@ static int axg_fifo_pcm_open(struct snd_pcm_substream *ss)

    ret = request_irq(fifo->irq, axg_fifo_pcm_irq_block, 0,
    dev_name(dev), ss);
    + if (ret)
    + return ret;

    /* Enable pclk to access registers and clock the fifo ip */
    ret = clk_prepare_enable(fifo->pclk);
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-11-08 13:13    [W:2.401 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site