lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 128/205] dmaengine: at_xdmac: remove a stray bottom half unlock
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 0b515abb6b7eb08e90bdfc01fc8fbdd112c15d81 ]

    We switched this code from spin_lock_bh() to vanilla spin_lock() but
    there was one stray spin_unlock_bh() that was overlooked. This
    patch converts it to spin_unlock() as well.

    Fixes: d8570d018f69 ("dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/at_xdmac.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
    index db5b8fe1dd4ab..7db66f974041e 100644
    --- a/drivers/dma/at_xdmac.c
    +++ b/drivers/dma/at_xdmac.c
    @@ -1608,7 +1608,7 @@ static void at_xdmac_tasklet(unsigned long data)
    dev_vdbg(chan2dev(&atchan->chan), "%s: desc 0x%p\n", __func__, desc);
    if (!desc->active_xfer) {
    dev_err(chan2dev(&atchan->chan), "Xfer not active: exiting");
    - spin_unlock_bh(&atchan->lock);
    + spin_unlock(&atchan->lock);
    return;
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2019-11-08 13:08    [W:4.038 / U:1.720 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site