lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 47/64] media: fix: media: pci: meye: validate offset to avoid arbitrary access
    Date
    From: Lao Wei <zrlw@qq.com>

    [ Upstream commit eac7230fdb4672c2cb56f6a01a1744f562c01f80 ]

    Motion eye video4linux driver for Sony Vaio PictureBook desn't validate user-controlled parameter
    'vma->vm_pgoff', a malicious process might access all of kernel memory from user space by trying
    pass different arbitrary address.
    Discussion: http://www.openwall.com/lists/oss-security/2018/07/06/1

    Signed-off-by: Lao Wei <zrlw@qq.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/pci/meye/meye.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/pci/meye/meye.c b/drivers/media/pci/meye/meye.c
    index ba887e8e1b171..a85c5199ccd30 100644
    --- a/drivers/media/pci/meye/meye.c
    +++ b/drivers/media/pci/meye/meye.c
    @@ -1469,7 +1469,7 @@ static int meye_mmap(struct file *file, struct vm_area_struct *vma)
    unsigned long page, pos;

    mutex_lock(&meye.lock);
    - if (size > gbuffers * gbufsize) {
    + if (size > gbuffers * gbufsize || offset > gbuffers * gbufsize - size) {
    mutex_unlock(&meye.lock);
    return -EINVAL;
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-11-08 12:53    [W:2.227 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site