lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 03/62] regulator: pfuze100-regulator: Variable "val" in pfuze100_regulator_probe() could be uninitialized
    Date
    From: Yizhuo <yzhai003@ucr.edu>

    [ Upstream commit 1252b283141f03c3dffd139292c862cae10e174d ]

    In function pfuze100_regulator_probe(), variable "val" could be
    initialized if regmap_read() fails. However, "val" is used to
    decide the control flow later in the if statement, which is
    potentially unsafe.

    Signed-off-by: Yizhuo <yzhai003@ucr.edu>
    Link: https://lore.kernel.org/r/20190929170957.14775-1-yzhai003@ucr.edu
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/pfuze100-regulator.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
    index 659e516455bee..4f205366d8aea 100644
    --- a/drivers/regulator/pfuze100-regulator.c
    +++ b/drivers/regulator/pfuze100-regulator.c
    @@ -632,7 +632,13 @@ static int pfuze100_regulator_probe(struct i2c_client *client,

    /* SW2~SW4 high bit check and modify the voltage value table */
    if (i >= sw_check_start && i <= sw_check_end) {
    - regmap_read(pfuze_chip->regmap, desc->vsel_reg, &val);
    + ret = regmap_read(pfuze_chip->regmap,
    + desc->vsel_reg, &val);
    + if (ret) {
    + dev_err(&client->dev, "Fails to read from the register.\n");
    + return ret;
    + }
    +
    if (val & sw_hi) {
    if (pfuze_chip->chip_id == PFUZE3000) {
    desc->volt_table = pfuze3000_sw2hi;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-08 20:21    [W:4.027 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site