lkml.org 
[lkml]   [2019]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.3 112/140] net/mlx5e: Initialize on stack link modes bitmap
    Date
    From: Aya Levin <ayal@mellanox.com>

    [ Upstream commit 926b37f76fb0a22fe93c8873c819fd167180e85c ]

    Initialize link modes bitmap on stack before using it, otherwise the
    outcome of ethtool set link ksettings might have unexpected values.

    Fixes: 4b95840a6ced ("net/mlx5e: Fix matching of speed to PRM link modes")
    Signed-off-by: Aya Levin <ayal@mellanox.com>
    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
    @@ -1021,7 +1021,7 @@ static bool ext_link_mode_requested(cons
    {
    #define MLX5E_MIN_PTYS_EXT_LINK_MODE_BIT ETHTOOL_LINK_MODE_50000baseKR_Full_BIT
    int size = __ETHTOOL_LINK_MODE_MASK_NBITS - MLX5E_MIN_PTYS_EXT_LINK_MODE_BIT;
    - __ETHTOOL_DECLARE_LINK_MODE_MASK(modes);
    + __ETHTOOL_DECLARE_LINK_MODE_MASK(modes) = {0,};

    bitmap_set(modes, MLX5E_MIN_PTYS_EXT_LINK_MODE_BIT, size);
    return bitmap_intersects(modes, adver, __ETHTOOL_LINK_MODE_MASK_NBITS);

    \
     
     \ /
      Last update: 2019-11-08 20:13    [W:6.134 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site