lkml.org 
[lkml]   [2019]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] hugetlbfs: Take read_lock on i_mmap for PMD sharing
    On Thu, Nov 07, 2019 at 02:06:28PM -0500, Waiman Long wrote:
    > - i_mmap_lock_write(mapping);
    > + /*
    > + * PMD sharing does not require changes to i_mmap. So a read lock
    > + * is enuogh.
    > + */
    > + i_mmap_lock_read(mapping);

    We don't have comments before any of the other calls to i_mmap_lock_read()
    justifying why we don't need the write lock. I don't understand why this
    situation is different. Just delete the comment and make this a two-line
    patch.

    \
     
     \ /
      Last update: 2019-11-07 20:43    [W:4.057 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site