Messages in this thread | | | Date | Thu, 7 Nov 2019 11:42:25 -0800 | From | Matthew Wilcox <> | Subject | Re: [PATCH] hugetlbfs: Take read_lock on i_mmap for PMD sharing |
| |
On Thu, Nov 07, 2019 at 02:06:28PM -0500, Waiman Long wrote: > - i_mmap_lock_write(mapping); > + /* > + * PMD sharing does not require changes to i_mmap. So a read lock > + * is enuogh. > + */ > + i_mmap_lock_read(mapping);
We don't have comments before any of the other calls to i_mmap_lock_read() justifying why we don't need the write lock. I don't understand why this situation is different. Just delete the comment and make this a two-line patch.
| |