Messages in this thread | | | Date | Thu, 7 Nov 2019 08:38:51 -0500 | From | Sean Paul <> | Subject | Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output |
| |
On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > DRM helper macro. > > The commit message should show the reason _why_ you are doing > this instead of just stating that you are doing this. > > It's not that dev_err is uncommon in drivers/gpu/drm. >
It is uncommon (this is the sole instance) in rockchip, however. So it makes sense to convert the dev_* prints in rockchip to DRM_DEV for consistency.
Wambui, could you also please convert the dev_warn instance as well?
I'll apply this to drm-misc-next and expand on the commit message a bit.
Thanks,
Sean
> $ git grep -w dev_err drivers/gpu/drm | wc -l > 1950 > $ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l > 756 > > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > [] > > @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev) > > } > > > > if (!dsi->cdata) { > > - dev_err(dev, "no dsi-config for %s node\n", np->name); > > + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); > > return -EINVAL; > > } > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Sean Paul, Software Engineer, Google / Chromium OS
| |