Messages in this thread | | | Date | Thu, 7 Nov 2019 21:35:07 +0800 | From | Leo Yan <> | Subject | Re: [PATCH v2] perf tests: Fix out of bounds memory access |
| |
On Thu, Nov 07, 2019 at 09:06:43AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 07, 2019 at 06:20:29PM +0800, Leo Yan escreveu: > > On Thu, Nov 07, 2019 at 10:42:26AM +0100, Jiri Olsa wrote: > > > [...] > > > > > To fix this issue, we will use evlist__open() and evlist__close() pair > > > > functions to prepare and cleanup context for evlist; so 'evsel->id' and > > > > 'evsel->ids' can be initialized properly when invoke do_test() and avoid > > > > the out of bounds memory access. > > > > right, we need to solve this on libperf level, so it's possible > > > to call mmap/munmap multiple time without close/open.. I'll try > > > to send something, but meanwhile this is good workaround > > > > > > Reviewed-by: Jiri Olsa <jolsa@kernel.org> > > > Thanks for reviewing, Jiri. > > > You are welcome to send us the fixing patches, I am glad to test it on > > qemu_arm. > > Thanks, applied after adding: > > Fixes: ee74701ed8ad ("perf tests: Add test to check backward ring buffer") > Cc: stable@vger.kernel.org # v4.10+ > > Please consider doing it next time,
Thanks a lot for helping to add 'Fixes' tag, Arnaldo.
Will note this for later patches.
Thanks, Leo Yan
| |