lkml.org 
[lkml]   [2019]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] tracing: Use seq_buf_hex_dump() to dump buffers
From
Date
On 2019-11-06 9:55, Steven Rostedt wrote:
> On Wed, 6 Nov 2019 07:27:40 +0100
> Piotr Maziarz <piotrx.maziarz@linux.intel.com> wrote:
>
>> Without this, buffers can be printed with __print_array macro that has
>> no formatting options and can be hard to read. The other way is to
>> mimic formatting capability with multiple calls of trace event with one
>> call per row which gives performance impact and different timestamp in
>> each row.
>>
>> Signed-off-by: Piotr Maziarz <piotrx.maziarz@linux.intel.com>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>> ---
>> include/linux/trace_events.h | 5 +++++
>> include/linux/trace_seq.h | 4 ++++
>> include/trace/trace_events.h | 6 ++++++
>> kernel/trace/trace_output.c | 15 +++++++++++++++
>> kernel/trace/trace_seq.c | 30 ++++++++++++++++++++++++++++++
>> 5 files changed, 60 insertions(+)
>>
>
> I'd like to see in the patch series (patch 3?) a use case of these
> added functionality. Or at least a link to what would be using it.
>
> Thanks!
>
> -- Steve
>

ASoC: Intel is an initial recipient for this feature. I have a patch for
this, but it should be also sent to alsa-devel mailing list, and since
hex_dump tracing isn't there yet I'm not sure how this patch series
should be sent.

Best regards,
Piotr Maziarz

\
 
 \ /
  Last update: 2019-11-07 13:18    [W:0.199 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site