Messages in this thread | | | Date | Thu, 7 Nov 2019 10:16:57 +0100 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v4 1/2] dt-bindings: gpu: mali-midgard: add samsung exynos 5420 compatible |
| |
On Thu, Nov 07, 2019 at 09:25:26AM +1030, Marian Mihailescu wrote: > Add "samsung,exynos5420-mali" binding > > Signed-off-by: Marian Mihailescu <mihailescu2m@gmail.com> > --- > Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml > index 47bc1ac36426..41b928bce4ea 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml > @@ -38,9 +38,12 @@ properties: > - enum: > - samsung,exynos5433-mali > - const: arm,mali-t760 > + - items: > + - enum: > + - samsung,exynos5420-mali > + - const: arm,mali-t628
I would prefer to order it logically/alphabetically, so after 5250 and before 5433. With that change:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards, Krzysztof
| |