Messages in this thread | | | Subject | Re: [PATCH] mtd: rawnand: driver for Mediatek MT7621 SoC NAND flash controller | From | Greg Ungerer <> | Date | Fri, 8 Nov 2019 14:34:15 +1000 |
| |
On 7/11/19 6:40 pm, Greg KH wrote: > On Thu, Nov 07, 2019 at 05:35:21PM +1000, gerg@kernel.org wrote: >> From: Greg Ungerer <gerg@kernel.org> >> >> Add a driver to support the NAND flash controller of the MediaTek MT7621 >> System-on-Chip device. (This one is the MIPS based parts from Mediatek). >> >> This code is a re-working of the earlier patches for this hardware that >> have been floating around the internet for years: >> >> https://github.com/ReclaimYourPrivacy/cloak/blob/master/target/linux/ramips/patches-3.18/0045-mtd-add-mt7621-nand-support.patch >> >> This is a much cleaned up version, put in staging to start with. >> It does still have some problems, mainly that it still uses a lot of the >> mtd raw nand legacy support. > > Is that an issue? Why not just put it in the "real" part of the kernel > then, if those apis are still in use?
Agreed. If the MTD folks have no problem with it.
>> The driver not only compiles, but it works well on the small range of >> hardware platforms that it has been used on so far. I have been using >> for quite a while now, cleaning up as I get time. >> >> So... I am looking for comments on the best approach forward with this. >> At least in staging it can get some more eyeballs going over it. > > staging will just nit-pick it to death for coding style issues, it's not > going to be get any major api changes/cleanups there usually. I'd > recommend just merging this to the "real" part of the kernel now if it's > working for you.
I'll spin a v2 based on Dan's feedback, and move it into drivers/mtd.
Thanks Greg
| |