Messages in this thread | | | Subject | Re: s390/pkey: Use memdup_user() rather than duplicating its implementation | From | Christian Borntraeger <> | Date | Thu, 7 Nov 2019 09:07:18 +0100 |
| |
On 07.11.19 07:48, Dan Carpenter wrote: > On Wed, Nov 06, 2019 at 07:30:19PM +0100, Christian Borntraeger wrote: >> >> >> On 06.11.19 14:00, Markus Elfring wrote: >>>>> Reuse existing functionality from memdup_user() instead of keeping >>>>> duplicate source code. >>>>> >>>>> Generated by: scripts/coccinelle/api/memdup_user.cocci >>> … >>>>> Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support") >>>> >>>> This doesn't fix anything >>> >>> How would you categorise the proposed source code reduction and software reuse? >> >> Cleanup. >> >> Can you please stop arguing about review feedback that is clearly right? This is not fixing >> anything. The Fixes tag is used to decide if something needs a backport. > > Fixes tags are independent from backports. If you want a backport you > should CC stable.
I agree, but a Fixes tag increases the likelyhood of automatic backports anyway. (e.g. some distro kernel maintainers check for this tag).
| |