Messages in this thread | | | Subject | Re: [PATCH v3 11/11] arm64: dts: qcom: sc7180: Add pdc interrupt controller | From | Rajendra Nayak <> | Date | Mon, 4 Nov 2019 11:47:19 +0530 |
| |
On 10/31/2019 1:20 AM, Matthias Kaehlcke wrote: > On Tue, Oct 29, 2019 at 09:50:40AM -0700, Stephen Boyd wrote: >> Quoting Rajendra Nayak (2019-10-23 02:02:19) >>> From: Maulik Shah <mkshah@codeaurora.org> >>> >>> Add pdc interrupt controller for sc7180 >>> >>> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> >>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> >>> --- >>> v3: >>> Used the qcom,sdm845-pdc compatible for pdc node >> >> Everything else isn't doing the weird old compatible thing. Why not just >> add the new compatible and update the driver? I guess I'll have to go >> read the history. > > Marc Zyngier complained on v2 about the churn from adding compatible > strings for identical components, and I kinda see his point. > > I agree that using the 'sdm845' compatible string for sc7180 is odd too. > Maybe we should introduce SoC independent compatible strings for IP blocks > that are shared across multiple SoCs? If differentiation is needed SoC > specific strings can be added.
Sure, I will perhaps add a qcom,pdc SoC independent compatible to avoid confusion.
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |