Messages in this thread | | | Date | Tue, 5 Nov 2019 00:43:29 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] timers/nohz: Update nohz load even if tick already stopped |
| |
On Mon, 4 Nov 2019, Thomas Gleixner wrote: > On Fri, 1 Nov 2019, Scott Wood wrote: > > On Wed, 2019-10-30 at 14:31 +0100, Peter Zijlstra wrote: > > > Oh argh! that's a bit radical of the remote tick. The normal tick runs > > > just fine on idle CPUs, so lets mirror that. > > > > > > How's this then? > > .... > > > > > Needs to be tick_nohz_tick_stopped_cpu(cpu) > > > > After fixing that, I get: > > > > [ 7.439068] WARNING: CPU: 20 PID: 7 at /home/root/linux/kernel/sched/core.c:3681 sched_tick_remote+0x132/0x150 > > So I'm going to apply Scotts patch if nobody comes up with a better idea > until tomorrow.
As Peter pointed out to me privately we should rather go and analyze the real thing instead of just applying duct tape.
/me drops the patch again.
| |