Messages in this thread | | | Date | Sun, 1 Dec 2019 11:08:10 +0800 | From | kbuild test robot <> | Subject | Re: [PATCH] Mips32 gettimeofday fix |
| |
Hi Vincenzo,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [cannot apply to v5.4 next-20191129] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Vincenzo-Frascino/Mips32-gettimeofday-fix/20191129-022306 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a6ed68d6468bd5a3da78a103344ded1435fed57a config: mips-jmr3927_defconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from <command-line>:0:0: lib/vdso/gettimeofday.c: In function '__cvdso_gettimeofday': >> lib/vdso/gettimeofday.c:152:11: error: implicit declaration of function 'gettimeofday_fallback'; did you mean 'clock_gettime32_fallback'? [-Werror=implicit-function-declaration] return gettimeofday_fallback(tv, tz); ^~~~~~~~~~~~~~~~~~~~~ clock_gettime32_fallback cc1: all warnings being treated as errors
vim +152 lib/vdso/gettimeofday.c
00b26474c2f161 Vincenzo Frascino 2019-06-21 142 00b26474c2f161 Vincenzo Frascino 2019-06-21 143 static __maybe_unused int 00b26474c2f161 Vincenzo Frascino 2019-06-21 144 __cvdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz) 00b26474c2f161 Vincenzo Frascino 2019-06-21 145 { 00b26474c2f161 Vincenzo Frascino 2019-06-21 146 const struct vdso_data *vd = __arch_get_vdso_data(); 00b26474c2f161 Vincenzo Frascino 2019-06-21 147 00b26474c2f161 Vincenzo Frascino 2019-06-21 148 if (likely(tv != NULL)) { 00b26474c2f161 Vincenzo Frascino 2019-06-21 149 struct __kernel_timespec ts; 00b26474c2f161 Vincenzo Frascino 2019-06-21 150 00b26474c2f161 Vincenzo Frascino 2019-06-21 151 if (do_hres(&vd[CS_HRES_COARSE], CLOCK_REALTIME, &ts)) 00b26474c2f161 Vincenzo Frascino 2019-06-21 @152 return gettimeofday_fallback(tv, tz); 00b26474c2f161 Vincenzo Frascino 2019-06-21 153 00b26474c2f161 Vincenzo Frascino 2019-06-21 154 tv->tv_sec = ts.tv_sec; 00b26474c2f161 Vincenzo Frascino 2019-06-21 155 tv->tv_usec = (u32)ts.tv_nsec / NSEC_PER_USEC; 00b26474c2f161 Vincenzo Frascino 2019-06-21 156 } 00b26474c2f161 Vincenzo Frascino 2019-06-21 157 00b26474c2f161 Vincenzo Frascino 2019-06-21 158 if (unlikely(tz != NULL)) { 00b26474c2f161 Vincenzo Frascino 2019-06-21 159 tz->tz_minuteswest = vd[CS_HRES_COARSE].tz_minuteswest; 00b26474c2f161 Vincenzo Frascino 2019-06-21 160 tz->tz_dsttime = vd[CS_HRES_COARSE].tz_dsttime; 00b26474c2f161 Vincenzo Frascino 2019-06-21 161 } 00b26474c2f161 Vincenzo Frascino 2019-06-21 162 00b26474c2f161 Vincenzo Frascino 2019-06-21 163 return 0; 00b26474c2f161 Vincenzo Frascino 2019-06-21 164 } 00b26474c2f161 Vincenzo Frascino 2019-06-21 165
:::::: The code at line 152 was first introduced by commit :::::: 00b26474c2f1613d7ab894c525f775c67c8a9e8f lib/vdso: Provide generic VDSO implementation
:::::: TO: Vincenzo Frascino <vincenzo.frascino@arm.com> :::::: CC: Thomas Gleixner <tglx@linutronix.de>
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation [unhandled content-type:application/gzip] | |