Messages in this thread | | | From | Cong Wang <> | Date | Fri, 29 Nov 2019 22:03:45 -0800 | Subject | Re: [Patch v2 3/3] iommu: avoid taking iova_rbtree_lock twice |
| |
On Fri, Nov 29, 2019 at 5:34 AM John Garry <john.garry@huawei.com> wrote: > > On 29/11/2019 00:48, Cong Wang wrote: > > Both find_iova() and __free_iova() take iova_rbtree_lock, > > there is no reason to take and release it twice inside > > free_iova(). > > > > Fold them into the critical section by calling the unlock > > versions instead. > > Since generally the iova would be non-NULL, this seems a reasonable > change (which could be mentioned in the commit log)
I think it is too obvious to mention it. There are many things we can mention but we should only mention what's necessary, right?
Thanks.
| |