Messages in this thread | | | From | Adam Ford <> | Date | Sat, 30 Nov 2019 16:49:58 -0600 | Subject | Re: [PATCH 2/2] arm64: dts: Add GPC Support |
| |
On Sat, Nov 30, 2019 at 4:30 PM Fabio Estevam <festevam@gmail.com> wrote: > > On Sat, Nov 30, 2019 at 7:25 PM Fabio Estevam <festevam@gmail.com> wrote: > > > > Hi Adam, > > > > On Fri, Nov 29, 2019 at 8:41 PM Adam Ford <aford173@gmail.com> wrote: > > > > > + > > > + gpc: gpc@303a0000 { > > > + compatible = "fsl,imx8mm-gpc"; > > > > You could do like this instead: > > > > compatible = "fsl,imx8mm-gpc", "fsl,imx8mq-gpc"; > > > > and then you don't need patch 1/2.
I like that idea.
> > > > Also, "fsl,imx8mm-gpc" needs to be documented.
I held off intentionally because of all the txt->yaml conversion, I didn't want to get stuck in the middle of that.
Would an tweak to the txt file be accepted?
If not, should I just use the "fsl,imx8mq-gpc" and leave it alone?
> > One more thing: when you add a v2, please specify the SoC name in the > subject line: > > arm64: dts: imx8mm: Add GPC Support
Good catch. Sorry about that.
adam
| |