lkml.org 
[lkml]   [2019]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 125/306] qlcnic: fix a return in qlcnic_dcb_get_capability()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit c94f026fb742b2d3199422751dbc4f6fc0e753d8 ]

    These functions are supposed to return one on failure and zero on
    success. Returning a zero here could cause uninitialized variable
    bugs in several of the callers. For example:

    drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:1660 get_iscsi_dcb_priority()
    error: uninitialized symbol 'caps'.

    Fixes: 48365e485275 ("qlcnic: dcb: Add support for CEE Netlink interface.")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c
    index 4b76c69fe86d2..834208e55f7b8 100644
    --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c
    +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c
    @@ -883,7 +883,7 @@ static u8 qlcnic_dcb_get_capability(struct net_device *netdev, int capid,
    struct qlcnic_adapter *adapter = netdev_priv(netdev);

    if (!test_bit(QLCNIC_DCB_STATE, &adapter->dcb->state))
    - return 0;
    + return 1;

    switch (capid) {
    case DCB_CAP_ATTR_PG:
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-27 22:00    [W:4.408 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site