Messages in this thread | | | Date | Wed, 27 Nov 2019 10:19:40 -0800 | From | Eric Biggers <> | Subject | Re: [PATCH v3] crypto: arm64/sha: fix function types |
| |
On Tue, Nov 19, 2019 at 12:13:53PM -0800, Sami Tolvanen wrote: > +static void __sha1_ce_transform(struct sha1_state *sst, u8 const *src, > + int blocks) > +{ > + return sha1_ce_transform(container_of(sst, struct sha1_ce_state, sst), > + src, blocks); > +} > +
'return' isn't needed in functions that return void.
Likewise everywhere else in this patch.
Otherwise this patch looks fine.
- Eric
| |