Messages in this thread | | | Subject | Re: [PATCH 1/1] arm64: dts: allwinner: a64: olinuxino: Add VCC-PG supply | From | Stefan Mavrodiev <> | Date | Wed, 27 Nov 2019 09:07:40 +0200 |
| |
On 11/26/19 6:27 PM, Maxime Ripard wrote: > Hi Stefan, > > On Tue, Nov 26, 2019 at 01:05:08PM +0200, Stefan Mavrodiev wrote: >> On A64-OLinuXino boards, PG9 is used for USB1 enable/disable. The >> port is supplied by DLDO4, which is disabled by default. The patch >> adds the regulator as vcc-pg, which is later used by the pinctrl. >> >> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com> >> --- >> arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts >> index 01a9a52edae4..c9d8c9c4ef20 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts >> @@ -163,6 +163,10 @@ >> status = "okay"; >> }; >> >> +&pio { >> + vcc-pg-supply=<®_dldo4>; > The equal sign should have spaces around it. > > Also, can you please list all the bank supplies while you're at it? Sure. Should the supplies defined as regulators names be added also to the pio node? For example reg_aldo1 is named "vcc-pe".
Also, since the commit message will be different for better representation of the changes, should I send the next patch as v2 or as a new one?
Best regards, Stefan > > Thanks! > Maxime
| |