Messages in this thread | | | From | Peng Ma <> | Subject | RE: [EXT] Re: [PATCH] i2c: imx: Defer probing if EDMA not available | Date | Thu, 28 Nov 2019 02:45:52 +0000 |
| |
>-----Original Message----- >From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >Sent: 2019年11月27日 15:27 >To: Peng Ma <peng.ma@nxp.com> >Cc: linux@rempel-privat.de; kernel@pengutronix.de; shawnguo@kernel.org; >s.hauer@pengutronix.de; linux-kernel@vger.kernel.org; dl-linux-imx ><linux-imx@nxp.com>; festevam@gmail.com; >linux-arm-kernel@lists.infradead.org; linux-i2c@vger.kernel.org >Subject: [EXT] Re: [PATCH] i2c: imx: Defer probing if EDMA not available > >Caution: EXT Email > >Hello, > >On Wed, Nov 27, 2019 at 07:12:09AM +0000, Peng Ma wrote: >> EDMA may be not available or defered due to dependencies on other >> modules, If these scenarios is encountered, we should defer probing. > >I'd write: > > i2c: imx: Defer probing if requesting DMA yields EPROBE_DEFER > > DMA might not be available yet when the i2c device probes. > Properly handle EPROBE_DEFER on dma channel allocation by > passing on this error. > >It would be nice to point out where/how this failed for you. > >Other than that this looks reasonable. > Hi, Uwe,
Thanks very much for your comments, That looks good.
Best Regards, Peng >Best regards >Uwe > >-- >Pengutronix e.K. | Uwe Kleine-König >| >Industrial Linux Solutions | >https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p >engutronix.de%2F&data=02%7C01%7Cpeng.ma%40nxp.com%7C426ec4f >5f1f14751022f08d7730b4043%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0 >%7C1%7C637104364470568722&sdata=JjD2ovy4oxZseUEUwNERASBJCk >0oMLSplb8qRTkhaTE%3D&reserved=0 |
| |