Messages in this thread | | | From | Qian Cai <> | Subject | Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn | Date | Wed, 27 Nov 2019 17:56:40 -0500 |
| |
> On Nov 27, 2019, at 3:49 PM, David Hildenbrand <david@redhat.com> wrote: > > (I am a friend of cleaning up and refactoring code to make it easier to > understand, maintain and extend. I was assuming your mentality is to > rather keeping code changes minimal if there is a chance to break things > - I'm sorry if that assumption was wrong.)
Yes, I tested linux-next everyday and saw enough of those cleanup efforts ends up introducing regressions. It is almost every day or two I had to investigate at least one regression and pick the suckers out even though my testing is only focus on MM and friends. However, I do agree if there are worthy cleanup and refactoring but those tiny ones make me uncomfortable. See, I am just trying to save a real vacation for a few weeks in the future, but given the current situation, I’ll need to give up on this project [1] at all because I just have no courage to debug all the regressions there once back.
[1] https://github.com/cailca/linux-mm
| |