lkml.org 
[lkml]   [2019]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 092/132] net: bcmgenet: return correct value ret from bcmgenet_power_down
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit 0db55093b56618088b9a1d445eb6e43b311bea33 ]

    Fixes gcc '-Wunused-but-set-variable' warning:

    drivers/net/ethernet/broadcom/genet/bcmgenet.c: In function 'bcmgenet_power_down':
    drivers/net/ethernet/broadcom/genet/bcmgenet.c:1136:6: warning:
    variable 'ret' set but not used [-Wunused-but-set-variable]

    bcmgenet_power_down should return 'ret' instead of 0.

    Fixes: ca8cf341903f ("net: bcmgenet: propagate errors from bcmgenet_power_down")
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    index 04fe570275cd6..34fae5576b603 100644
    --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    @@ -1074,7 +1074,7 @@ static int bcmgenet_power_down(struct bcmgenet_priv *priv,
    break;
    }

    - return 0;
    + return ret;
    }

    static void bcmgenet_power_up(struct bcmgenet_priv *priv,
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-27 22:44    [W:4.065 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site