lkml.org 
[lkml]   [2019]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 09/66] x86/insn: Fix awk regexp warnings
    Date
    From: Alexander Kapshuk <alexander.kapshuk@gmail.com>

    commit 700c1018b86d0d4b3f1f2d459708c0cdf42b521d upstream.

    gawk 5.0.1 generates the following regexp warnings:

    GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
    awk: ../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
    awk: ../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operator

    Ealier versions of gawk are not known to generate these warnings. The
    gawk manual referenced below does not list characters ':' and '&' as
    needing escaping, so 'unescape' them. See

    https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html

    for more info.

    Running diff on the output generated by the script before and after
    applying the patch reported no differences.

    [ bp: Massage commit message. ]

    [ Caught the respective tools header discrepancy. ]
    Reported-by: kbuild test robot <lkp@intel.com>
    Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
    Signed-off-by: Borislav Petkov <bp@suse.de>
    Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: x86-ml <x86@kernel.org>
    Link: https://lkml.kernel.org/r/20190924044659.3785-1-alexander.kapshuk@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/tools/gen-insn-attr-x86.awk | 4 ++--
    tools/arch/x86/tools/gen-insn-attr-x86.awk | 4 ++--
    2 files changed, 4 insertions(+), 4 deletions(-)

    --- a/arch/x86/tools/gen-insn-attr-x86.awk
    +++ b/arch/x86/tools/gen-insn-attr-x86.awk
    @@ -69,7 +69,7 @@ BEGIN {

    lprefix1_expr = "\\((66|!F3)\\)"
    lprefix2_expr = "\\(F3\\)"
    - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)"
    + lprefix3_expr = "\\((F2|!F3|66&F2)\\)"
    lprefix_expr = "\\((66|F2|F3)\\)"
    max_lprefix = 4

    @@ -257,7 +257,7 @@ function convert_operands(count,opnd,
    return add_flags(imm, mod)
    }

    -/^[0-9a-f]+\:/ {
    +/^[0-9a-f]+:/ {
    if (NR == 1)
    next
    # get index
    --- a/tools/arch/x86/tools/gen-insn-attr-x86.awk
    +++ b/tools/arch/x86/tools/gen-insn-attr-x86.awk
    @@ -69,7 +69,7 @@ BEGIN {

    lprefix1_expr = "\\((66|!F3)\\)"
    lprefix2_expr = "\\(F3\\)"
    - lprefix3_expr = "\\((F2|!F3|66\\&F2)\\)"
    + lprefix3_expr = "\\((F2|!F3|66&F2)\\)"
    lprefix_expr = "\\((66|F2|F3)\\)"
    max_lprefix = 4

    @@ -257,7 +257,7 @@ function convert_operands(count,opnd,
    return add_flags(imm, mod)
    }

    -/^[0-9a-f]+\:/ {
    +/^[0-9a-f]+:/ {
    if (NR == 1)
    next
    # get index

    \
     
     \ /
      Last update: 2019-11-27 22:17    [W:4.601 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site