lkml.org 
[lkml]   [2019]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 212/306] btrfs: avoid link error with CONFIG_NO_AUTO_INLINE
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit 7e17916b35797396f681a3270245fd29c1e4c250 ]

    Note: this patch fixes a problem in a feature outside of btrfs ("kernel
    hacking: add a config option to disable compiler auto-inlining") and is
    applied ahead of time due to cross-subsystem dependencies.

    On 32-bit ARM with gcc-8, I see a link error with the addition of the
    CONFIG_NO_AUTO_INLINE option:

    fs/btrfs/super.o: In function `btrfs_statfs':
    super.c:(.text+0x67b8): undefined reference to `__aeabi_uldivmod'
    super.c:(.text+0x67fc): undefined reference to `__aeabi_uldivmod'
    super.c:(.text+0x6858): undefined reference to `__aeabi_uldivmod'
    super.c:(.text+0x6920): undefined reference to `__aeabi_uldivmod'
    super.c:(.text+0x693c): undefined reference to `__aeabi_uldivmod'
    fs/btrfs/super.o:super.c:(.text+0x6958): more undefined references to `__aeabi_uldivmod' follow

    So far this is the only file that shows the behavior, so I'd propose
    to just work around it by marking the functions as 'static inline'
    that normally get inlined here.

    The reference to __aeabi_uldivmod comes from a div_u64() which has an
    optimization for a constant division that uses a straight '/' operator
    when the result should be known to the compiler. My interpretation is
    that as we turn off inlining, gcc still expects the result to be constant
    but fails to use that constant value.

    Link: https://lkml.kernel.org/r/20181103153941.1881966-1-arnd@arndb.de
    Reviewed-by: Nikolay Borisov <nborisov@suse.com>
    Reviewed-by: Changbin Du <changbin.du@gmail.com>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    [ add the note ]
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/btrfs/super.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
    index 8888337a95b64..ddbad8d509490 100644
    --- a/fs/btrfs/super.c
    +++ b/fs/btrfs/super.c
    @@ -1919,7 +1919,7 @@ static int btrfs_remount(struct super_block *sb, int *flags, char *data)
    }

    /* Used to sort the devices by max_avail(descending sort) */
    -static int btrfs_cmp_device_free_bytes(const void *dev_info1,
    +static inline int btrfs_cmp_device_free_bytes(const void *dev_info1,
    const void *dev_info2)
    {
    if (((struct btrfs_device_info *)dev_info1)->max_avail >
    @@ -1948,8 +1948,8 @@ static inline void btrfs_descending_sort_devices(
    * The helper to calc the free space on the devices that can be used to store
    * file data.
    */
    -static int btrfs_calc_avail_data_space(struct btrfs_fs_info *fs_info,
    - u64 *free_bytes)
    +static inline int btrfs_calc_avail_data_space(struct btrfs_fs_info *fs_info,
    + u64 *free_bytes)
    {
    struct btrfs_device_info *devices_info;
    struct btrfs_fs_devices *fs_devices = fs_info->fs_devices;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-27 22:04    [W:2.261 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site