lkml.org 
[lkml]   [2019]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] media: ov5640: Fix check for PLL1 exceeding max allowed rate
    On Tue, Oct 29, 2019 at 7:42 AM Adam Ford <aford173@gmail.com> wrote:
    >
    > The variable _rate is by ov5640_compute_sys_clk() which returns
    > zero if the PLL exceeds 1GHz. Unfortunately, the check to see
    > if the max PLL1 output is checking 'rate' and not '_rate' and
    > 'rate' does not ever appear to be 0.
    >
    > This patch changes the check against the returned value of
    > '_rate' to determine if the PLL1 output exceeds 1GHz.
    >
    > Fixes: aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate")
    >

    I haven't seen any responses to this patch. Has anyone had a chance
    to review this? It's been nearly a month.
    I think it would be appropriate to backport to stable if deemed acceptable.

    adam

    > Signed-off-by: Adam Ford <aford173@gmail.com>
    >
    > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
    > index 5e495c833d32..bb968e764f31 100644
    > --- a/drivers/media/i2c/ov5640.c
    > +++ b/drivers/media/i2c/ov5640.c
    > @@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
    > * We have reached the maximum allowed PLL1 output,
    > * increase sysdiv.
    > */
    > - if (!rate)
    > + if (!_rate)
    > break;
    >
    > /*
    > --
    > 2.17.1
    >

    \
     
     \ /
      Last update: 2019-11-27 03:08    [W:6.021 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site