Messages in this thread | ![/](/images/icornerl.gif) | | From | Kalle Valo <> | Subject | Re: [PATCH 2/3] drivers: net: intel: Fix -Wcast-function-type | Date | Mon, 25 Nov 2019 17:56:03 +0000 |
| |
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 11/25/19 9:02 AM, Phong Tran wrote: >> correct usage prototype of callback in tasklet_init(). >> Report by https://github.com/KSPP/linux/issues/20 >> >> Signed-off-by: Phong Tran <tranmanphong@gmail.com> >> --- >> drivers/net/wireless/intel/ipw2x00/ipw2100.c | 7 ++++--- >> drivers/net/wireless/intel/ipw2x00/ipw2200.c | 5 +++-- >> drivers/net/wireless/intel/iwlegacy/3945-mac.c | 5 +++-- >> drivers/net/wireless/intel/iwlegacy/4965-mac.c | 5 +++-- >> 4 files changed, 13 insertions(+), 9 deletions(-) > > This patch is "fixing" three different drivers and should be split > into at least two parts. To be consistent with previous practices, the > subject for the two should be "intel: ipw2100: ...." and "intel: > iwlegacy: ...."
Actually, please drop even "intel:". So "ipw2x00: " and "iwlegacy: " is enough.
-- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| ![\](/images/icornerr.gif) |