Messages in this thread | | | From | Navid Emamdoost <> | Date | Thu, 21 Nov 2019 12:17:52 -0600 | Subject | Re: [PATCH] drm/vmwgfx: prevent memory leak in vmw_cmdbuf_res_add |
| |
On Tue, Sep 24, 2019 at 11:38 PM Navid Emamdoost <navid.emamdoost@gmail.com> wrote: > > In vmw_cmdbuf_res_add if drm_ht_insert_item fails the allocated memory > for cres should be released. > > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Would you please review this patch?
Thanks,
> --- > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c > index 4ac55fc2bf97..44d858ce4ce7 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c > @@ -209,8 +209,10 @@ int vmw_cmdbuf_res_add(struct vmw_cmdbuf_res_manager *man, > > cres->hash.key = user_key | (res_type << 24); > ret = drm_ht_insert_item(&man->resources, &cres->hash); > - if (unlikely(ret != 0)) > + if (unlikely(ret != 0)) { > + kfree(cres); > goto out_invalid_key; > + } > > cres->state = VMW_CMDBUF_RES_ADD; > cres->res = vmw_resource_reference(res); > -- > 2.17.1 >
-- Navid.
| |