| Subject | Re: [PATCH v4 02/10] lib: introduce generic min max heap | From | Joe Perches <> | Date | Thu, 21 Nov 2019 03:11:06 -0800 |
| |
On Fri, 2019-11-15 at 17:18 -0800, Ian Rogers wrote: > Supports push, pop and converting an array into a heap. > Based-on-work-by: Peter Zijlstra (Intel) <peterz@infradead.org> [] > diff --git a/include/linux/min_max_heap.h b/include/linux/min_max_heap.h [] > +/* Sift the element at pos down the heap. */ > +static inline void min_max_heapify(struct min_max_heap *heap, int pos, > + const struct min_max_heap_callbacks *func)
s/inline/__always_inline/g
> +static void min_max_heap_pop_push(struct min_max_heap *heap, > + const void *element, > + const struct min_max_heap_callbacks *func)
And this still misses the inline attribute
|